Skip to content

GH#1015: fix: guard empty-hash transient deletion in handle_site_export() #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
superdav42 merged 1 commit into from
Apr 30, 2026
Merged

GH#1015: fix: guard empty-hash transient deletion in handle_site_export() #1034

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion inc/site-exporter/class-site-exporter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@
*/
public function setup(): void {

add_action('wu_export_site', [$this, 'handle_site_export'], 10, 3);

Check warning on line 71 in inc/site-exporter/class-site-exporter.php

View workflow job for this annotation

GitHub Actions / Code Quality Checks 

Action callback returns WP_Error|true but should not return anything.

add_action('wu_import_site', [$this, 'handle_site_import']);

Check warning on line 73 in inc/site-exporter/class-site-exporter.php

View workflow job for this annotation

GitHub Actions / Code Quality Checks 

Action callback returns bool but should not return anything.

add_filter('wu_site_exporter_files_to_zip', [$this, 'maybe_exclude_wp_ultimo_plugins']);

Expand Down Expand Up @@ -1625,7 +1625,9 @@

wu_exporter_save_generation_time($export_name, $time);

wu_exporter_delete_transient("wu_pending_site_export_{$hash}");
if ( ! empty($hash)) {
wu_exporter_delete_transient("wu_pending_site_export_{$hash}");
}

return true;
}
Expand Down
Loading