Skip to content

fix: harden cookie-less sso token redirects#1087

Closed
superdav42 wants to merge 1 commit into
mainfrom
feature/auto-20260504-150241-gh1086
Closed

fix: harden cookie-less sso token redirects#1087
superdav42 wants to merge 1 commit into
mainfrom
feature/auto-20260504-150241-gh1086

Conversation

@superdav42

Copy link
Copy Markdown
Collaborator

Summary

  • Moves cookie-less SSO token consumption into Ultimate Multisite on init so mapped subsites can authenticate from wu_sso_token without the multi-tenancy cookie flow.
  • Preserves cross-domain redirect_to admin URLs, supports custom /login/ pages through template_redirect, and binds tokens to an audience host plus one-time jti transient.

Testing

  • php -l inc/sso/class-sso.php
  • vendor/bin/phpstan analyse inc/sso/class-sso.php --memory-limit=1G
  • vendor/bin/phpcs inc/sso/class-sso.php (blocked: configured WordPress.Arrays.ArrayDeclaration.* sniffs are unavailable after composer install)

For #1086


aidevops.sh v3.14.51 plugin for OpenCode v1.14.33 with gpt-5.5 spent 3m and 80,442 tokens on this as a headless worker.

@coderabbitai

coderabbitai Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Warning

Rate limit exceeded

@superdav42 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 59 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 20e8f7df-0409-45b3-9736-9fab7280527f

📥 Commits

Reviewing files that changed from the base of the PR and between 1d8472e and 893a22e.

📒 Files selected for processing (1)
  • inc/sso/class-sso.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/auto-20260504-150241-gh1086

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@superdav42

Copy link
Copy Markdown
Collaborator Author

aidevops.sh v3.14.51 plugin for OpenCode v1.14.33 with gpt-5.5 spent 3m and 83,021 tokens on this as a headless worker.

@superdav42

Copy link
Copy Markdown
Collaborator Author

DISPATCH_CLAIM nonce=700f929a63bd5219af701a52427218bc runner=superdav42 ts=2026-05-04T21:06:48Z max_age_s=1800 version=3.14.51 opencode_version=1.14.33

@superdav42 superdav42 added status:queued Worker dispatched, not yet started origin:worker Auto-created by pulse labelless backfill (t2112) labels May 4, 2026
@superdav42 superdav42 self-assigned this May 4, 2026
@superdav42

Copy link
Copy Markdown
Collaborator Author

Dispatching worker (deterministic).

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@superdav42 superdav42 added status:in-review PR open, awaiting review/merge and removed status:queued Worker dispatched, not yet started labels May 4, 2026
@superdav42

Copy link
Copy Markdown
Collaborator Author

CLAIM_RELEASED reason=clean runner=dave ts=2026-05-04T21:10:18Z aidevops_version=3.14.51 opencode_version=1.14.33 exit=0 session_count=1

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

Performance Test Results

Performance test results for 1651e6f are in 🛎️!

Note: the numbers in parentheses show the difference to the previous (baseline) test run. Differences below 2% or 0.5 in absolute values are not shown.

URL: /

Run DB Queries Memory Before Template Template WP Total LCP TTFB LCP - TTFB
0 40 (-1 / -3% ) 37.78 MB 833.50 ms (-22.00 ms / -3% ) 151.50 ms (-19.00 ms / -13% ) 1075.50 ms 1992.00 ms 1907.30 ms 87.95 ms (-2.00 ms / -2% )
1 56 49.10 MB 885.50 ms (-60.50 ms / -7% ) 145.50 ms (-3.00 ms / -2% ) 1031.50 ms (-63.50 ms / -6% ) 2002.00 ms (-80.00 ms / -4% ) 1914.40 ms (-84.90 ms / -4% ) 82.65 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

origin:worker Auto-created by pulse labelless backfill (t2112) status:in-review PR open, awaiting review/merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant