Skip to content

fix(template-switching): tighten sentinel guard to allow sites with no current template to switch #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
superdav42 merged 1 commit into from
May 11, 2026
Merged

fix(template-switching): tighten sentinel guard to allow sites with no current template to switch #1179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions assets/js/template-switching.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,12 @@
* initialised" and bail out — the watcher will fire
* again on the next legitimate template change.
*/
// eslint-disable-next-line eqeqeq
if (this.original_template_id == -1 || this.original_template_id <= 0) {
// Only -1 is the "not yet bound" sentinel (the data() default).
// 0 is a real, valid state meaning "site has no current template"
// — the customer must still be able to pick a template from the
// grid in that case. Use < 0 to also cover any future negative
// sentinel without re-introducing the 0 foot-gun.
if (this.original_template_id < 0) {

return;

Expand Down
Loading