fix(e2e): use API login for modal form error spec

[superdav42]

Summary

Follow-up for #1282 / #1281 after Cypress showed the modal-form spec still depended on UI login fields.

• Switch 030-modal-form-error-handling.spec.js from UI login to API login.
• Keeps the modal assertions focused on WU AJAX error handling rather than login page markup.

Verification

• node --check tests/e2e/cypress/integration/030-modal-form-error-handling.spec.js — passed.
• git diff --check — passed.

For #1282
For #1281

[coderabbitai]

Warning

Review limit reached

@superdav42, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 10 minutes and 33 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5c9abd76-b88c-4904-9746-8334c5dbf7b6

📥 Commits

Reviewing files that changed from the base of the PR and between 90cf9cd and 1f0c876.

📒 Files selected for processing (1)

• tests/e2e/cypress/integration/030-modal-form-error-handling.spec.js

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/e2e-modal-api-login

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[superdav42]

MERGE_SUMMARY

Summary

• Switched 030-modal-form-error-handling.spec.js to cy.loginByApi() so the spec is not blocked by custom login page field shape.

Verification

• node --check tests/e2e/cypress/integration/030-modal-form-error-handling.spec.js — passed.
• git diff --check — passed.

Commit: 1f0c876

[github-actions]

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

• Build: ultimate-multisite
• ⬇️ Download from GitHub Actions
• ⬇️ Download without Github Account (nightly.link)

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

[superdav42]

Summary

Follow-up for #1282 / #1281 after Cypress showed the modal-form spec still depended on UI login fields.

• Switch 030-modal-form-error-handling.spec.js from UI login to API login.
• Keeps the modal assertions focused on WU AJAX error handling rather than login page markup.

Verification

• node --check tests/e2e/cypress/integration/030-modal-form-error-handling.spec.js — passed.
• git diff --check — passed.
  For fix(e2e): stabilize Cypress login on custom login pages #1282
  For fix(tours): mark one-shot tours as finished on render to stop them repeating on every page load #1281

---

Merged via PR #1283 to main.
Merged by deterministic merge pass (pulse-wrapper.sh).

---

aidevops.sh v3.19.5 spent 40s on this as a headless bash routine.

[github-actions]

Performance Test Results

Performance test results for 87d36c0 are in 🛎️!

Note: the numbers in parentheses show the difference to the previous (baseline) test run. Differences below 2% or 0.5 in absolute values are not shown.

URL: /

Run	DB Queries	Memory	Before Template	Template	WP Total	LCP	TTFB	LCP - TTFB
0	41	37.78 MB	893.00 ms (+31.50 ms / +4% )	166.00 ms	1099.50 ms	2076.00 ms (+144.00 ms / +7% )	1986.80 ms (+127.95 ms / +6% )	77.00 ms (-2.05 ms / -3% )
1	56	49.13 MB	939.50 ms	146.00 ms	1085.00 ms	2060.00 ms	1988.95 ms	70.95 ms