Skip to content

fix: skip incomplete nested objects during duplication#1422

Merged
superdav42 merged 1 commit into
mainfrom
fix/checkout-nested-incomplete-object
Jun 13, 2026
Merged

fix: skip incomplete nested objects during duplication#1422
superdav42 merged 1 commit into
mainfrom
fix/checkout-nested-incomplete-object

Conversation

@superdav42

Copy link
Copy Markdown
Collaborator

Summary

  • preserve nested __PHP_Incomplete_Class values that appear after serialized arrays/objects are unserialized during duplication
  • extend the incomplete-object regression to cover nested object payloads while still rewriting scalar URLs in the same payload

Why

  • production checkout still aborted after PR fix: preserve incomplete objects during duplication #1419 because the missing Yoast object was nested inside an unserialized payload and hit the generic object mutation branch
  • this keeps checkout provisioning from aborting after tenant DB creation but before pending-site cleanup and blogmeta assignment

Verification

  • php -l inc/duplication/data.php
  • php -l tests/WP_Ultimo/Duplication/MUCD_Data_Test.php
  • WP-CLI probe: warnings=0 old=yes new=yes for nested incomplete object payload
  • git diff --check

Notes

  • vendor/bin/phpunit --filter MUCD_Data_Test remains blocked locally by missing /tmp/wordpress-tests-lib/includes/functions.php

aidevops.sh v3.20.58 plugin for OpenCode v1.17.4 with gpt-5.5 spent 21h 59m and 2,624,029 tokens on this with the user in an interactive session.

@superdav42 superdav42 added the origin:interactive Created by interactive user session label Jun 13, 2026
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@superdav42, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 1 minute and 25 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b29abfbd-57d0-4f89-8aa8-ba8799261583

📥 Commits

Reviewing files that changed from the base of the PR and between b730746 and d6341fa.

📒 Files selected for processing (2)
  • inc/duplication/data.php
  • tests/WP_Ultimo/Duplication/MUCD_Data_Test.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/checkout-nested-incomplete-object

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

🔨 Build Complete - Ready for Testing!

📦 Download Build Artifact (Recommended)

Download the zip build, upload to WordPress and test:

🌐 Test in WordPress Playground (Very Experimental)

Click the link below to instantly test this PR in your browser - no installation needed!
Playground support for multisite is very limitied, hopefully it will get better in the future.

🚀 Launch in Playground

Login credentials: admin / password

@superdav42 superdav42 merged commit 6c1bfdb into main Jun 13, 2026
12 checks passed
@superdav42 superdav42 deleted the fix/checkout-nested-incomplete-object branch June 13, 2026 17:08
@superdav42 superdav42 added the review-feedback-scanned Merged PR already scanned for quality feedback label Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

origin:interactive Created by interactive user session review-feedback-scanned Merged PR already scanned for quality feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant