Hotfix panel #238
Merged
Hotfix panel #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
Author
|
Not sure how helpful panels would be for |
Closed
Collaborator
Author
|
The test will produce this when saved but not when viewing. This is not related to the PR I believe, but should be marked as suspicious for the future.
|
Collaborator
Author
|
The PR now contains the HEAD of #236 |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a hotfix that addresses missing functions along with updates to tests for geographic plotting and formatting. Key changes include:
- Adding a new test for geo panels and colorbar behavior in geographic plots.
- Adjusting assertions and share parameter usage in formatting and axis sharing tests.
- Updating the border axes detection logic and introducing a helper for panel group membership in GeoAxes.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ultraplot/tests/test_geographic.py | Added colorbar testing and updated assertions for shared labels. |
| ultraplot/tests/test_format.py | Updated test calls to include explicit share parameters. |
| ultraplot/tests/test_axes.py | Revised label visibility assertions and removed duplicate helpers. |
| ultraplot/figure.py | Refined border axes detection with a grid-based approach. |
| ultraplot/axes/geo.py | Introduced panel group membership logic and improved sharing logic. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
* Deprecate basemap. Basemap will be deprecated in the next major release (v2.0). See Ultraplot#243 for context.
* simplified logic and basing reference on original grid * rm print statements * spelling * Update ultraplot/figure.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * do more comprehensive checking * rm debug * add some reasoning * fixed * add a stale check * compound tests and check for the failure * update calls * update tests * formatting restored to defaults * don't adjust labels when not sharing * tests pass -- some expected failures * rm debug statements * fix test * Update ultraplot/tests/test_geographic.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update ultraplot/figure.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update ultraplot/axes/geo.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Revert changes * rm duplicate * fixes --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
beckermr
requested changes
Jun 2, 2025
beckermr
approved these changes
Jun 3, 2025
cvanelteren
added a commit
that referenced
this pull request
Aug 14, 2025
* simplified logic and basing reference on original grid * rm print statements * spelling * Update ultraplot/figure.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * do more comprehensive checking * rm debug * add some reasoning * fixed * add a stale check * compound tests and check for the failure * fixed missing functions in grid * need to fix test * update calls * update tests * formatting restored to defaults * don't adjust labels when not sharing * tests pass -- some expected failures * rm debug statements * fix test * added tests * updated test to check for sharing of panels * update test * update test * Update ultraplot/tests/test_geographic.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * rm unnecessary funcs * Deprecate basemap (#243) * Deprecate basemap. Basemap will be deprecated in the next major release (v2.0). See #243 for context. * Hotfix get_border_axes (#236) * simplified logic and basing reference on original grid * rm print statements * spelling * Update ultraplot/figure.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * do more comprehensive checking * rm debug * add some reasoning * fixed * add a stale check * compound tests and check for the failure * update calls * update tests * formatting restored to defaults * don't adjust labels when not sharing * tests pass -- some expected failures * rm debug statements * fix test * Update ultraplot/tests/test_geographic.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update ultraplot/figure.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update ultraplot/axes/geo.py Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Revert changes * rm duplicate * fixes --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * refactor panel_group_member * mv logic to base * mv to the correct spot --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some functions that were missing. This would address #237