Refactor colorbar loc handling

[cvanelteren]

minor adjustment of #301

This PR is now a refactor of how the label positioning is handled. It moves the ugly block to a much easier to read helper function with some internal checking.

Important changes:

• label can now be placed independent of the orientation
• the label will now be rotated -90 degree for vertical colorbars by default to ensure visual fidelity across the kinds of plots (inset, figure, or axis).

I will need to add some tests to test this properly and still adjust the bbox handling with this new approach.

[beckermr]

Do we want to add a test for this by adding an image to our image comparison tests?

[cvanelteren]

Yes. Hold on. It's a bit tricky as the vert bars suffer from looking bad if you open the figure in gtk but look good on save

[cvanelteren]

Was drafting a release and noticed this

[codecov]

Codecov Report

❌ Patch coverage is 86.53846% with 21 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
ultraplot/axes/base.py	84.25%	10 Missing and 10 partials ⚠️
ultraplot/tests/test_colorbar.py	96.55%	0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

[cvanelteren]

Need to fix the framing for the inset

[cvanelteren]

Ok I sat down and went through all the edge cases but I think I got it looking relatively nice now. I am afraid, however, that the tests will indicate a visual difference since the logic is now concerning all the locations for insets.

[cvanelteren]

The resulting tests look good but differ in shape. Not sure why but likely related to the newly added refactors. Otherwise visually looks good.

[cvanelteren]

See above for changes @beckermr

[cvanelteren]

Can we go ahead an merge this @beckermr? I manually checked the errors and there is an image dimension error but visually they look similar.

[beckermr]

yes merge away!