Handle non homogeneous arrays #318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for handling non-homogeneous arrays in violin and box plots by implementing graceful fallback to dtype=object when numpy.atleast_1d() fails. This addresses issue #317 where arrays with different dimensions couldn't be processed.
- Modified
_to_numpy_arrayto catch exceptions and fallback to object dtype for non-homogeneous data - Added comprehensive test coverage for various data type scenarios
- Added specific test for inhomogeneous violin plots
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ultraplot/internals/inputs.py | Implements try-except block to handle non-homogeneous arrays with object dtype fallback |
| ultraplot/tests/test_inputs.py | Adds parametrized tests for _to_numpy_array function with various data types |
| ultraplot/tests/test_plot.py | Adds test for inhomogeneous violin plot functionality |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
beckermr
approved these changes
Aug 11, 2025
cvanelteren
added a commit
that referenced
this pull request
Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will attempt to parse the data inputs as a
dtype=objectif the input has different dimensions as was the case in #317. This would allow for more flexible parsing in violin and boxplots.