Skip to content

Revert "Fix edge case where vcenter is not properly set for diverging norms" #337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cvanelteren merged 1 commit into from
Aug 27, 2025
Merged

Revert "Fix edge case where vcenter is not properly set for diverging norms" #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions ultraplot/axes/plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2707,13 +2707,6 @@ def _parse_cmap(

# Create the continuous normalizer.
norm = _not_none(norm, "div" if "diverging" in trues else "linear")
# If using a diverging norm, fair=True, and vcenter not set, default to midpoint
if norm in ("div", "diverging") or "diverging" in trues:
fair = norm_kw.get("fair", True) # defaults to True
vcenter = norm_kw.get("vcenter", 0)
if fair and vcenter is None and vmin is not None and vmax is not None:
vcenter = 0.5 * (vmin + vmax)
norm_kw["vcenter"] = vcenter
if isinstance(norm, mcolors.Normalize):
norm.vmin, norm.vmax = vmin, vmax
else:
Expand Down Expand Up @@ -2946,6 +2939,7 @@ def _parse_level_lim(
f"Incompatible arguments vmin={vmin!r}, vmax={vmax!r}, and "
"symmetric=True. Ignoring the latter."
)

return vmin, vmax, kwargs

def _parse_level_num(
Expand Down
37 changes: 0 additions & 37 deletions ultraplot/tests/test_color.py
View file
Open in desktop

This file was deleted.