-
Notifications
You must be signed in to change notification settings - Fork 18
Feature: Allow multi-span colorbars #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
beckermr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get why span/rows/cols start with the first column at 1 instead of at 0. Has it always been this way?
It makes this code confusing:
fig.colorbar(cm, ax=axs[0, 0], span=(1, 2), loc="bottom")
The axes indices are offset by 1 from the span values.
beckermr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NVM it has been that way always. Very confusing but it is what it is.
I read it as |
Closes #393
Closes #392
Enables
fig.colorbar()to use bothax(positioning) andspan/rows/cols(extent) parameters together. Previously, span was ignored whenaxwas provided.Examples
Notes
span=orcols=for horizontal colorbars (top/bottom)rows=for vertical colorbars (left/right)fig.colorbar(cm, ax=axs[:])still workstest_colorbar.py