fix: preserve label add_data precision after PR #279#280
Merged
Conversation
Collaborator
|
fixes #278 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #279.
Label.add_data()needs a small precision fix: inserting a sub-secondTimedeltainto a label withtimedelta64[s]index should preserve fractional seconds, but we also must not downcast existing higher-resolution entries.This keeps the implementation simple by normalizing non-empty label
time_indexvalues totimedelta64[ns]beforesearchsorted/insert. It also adds two focused regression tests: one for the original 1.5s case and one to ensure existing ns-precision entries stay intact.Local validation:
uv run pytest tests/test_timeseries.py -q