fix: resolve OutOfBoundsTimedelta in compute_ventilation_volumes #285#286
Merged
Merged
Conversation
…razMath#285 Drop .tolist() on datetime64[ns] arrays in compute_reverse_airflow_labels to avoid nanosecond values being misinterpreted as seconds. Also remove the len > 0 guard in IntervalLabel.__init__ so empty (0, 2) arrays are reshaped to 1-D before reaching pd.to_timedelta. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.tolist()ondatetime64[ns]arrays incompute_reverse_airflow_labels: calling.tolist()converted each element to a Pythonint(nanoseconds since epoch), whichTimeSeriesBase.__init__then misinterpreted as seconds, overflowingtimedelta64[ns].len > 0guard inIntervalLabel.__init__: empty(0, 2)arrays (no reverse airflow intervals present) were bypassing the 2D→1D reshape and reachingpd.to_timedeltaas a 2D array, which it rejects withTypeError.Test plan
TestComputeVentilationVolumes::test_compute_ventilation_volumes_basic_outputsnow passes (was failing before this fix)153 passed)Closes #285
🤖 Generated with Claude Code