Renames#1299
Merged
Merged
Conversation
dopplershift
added
Area: Calc
jthielen
reviewed
Jan 13, 2020
Collaborator
jthielen
left a comment
jthielen
left a comment
There was a problem hiding this comment.
Generally looks good to me! Just a couple things I noticed going through this:
| @preprocess_xarray | ||
| @check_units('[pressure]', '[speed]', '[speed]', '[length]', '[speed]', '[speed]') | ||
| def critical_angle(pressure, u, v, heights, stormu, stormv): | ||
| def critical_angle(pressure, u, v, height, stormu, stormv): |
Collaborator
There was a problem hiding this comment.
Is this a signature to keep as-is? The two things that stood out to me as unexpected (based on the new quasi-standard) are:
- having the two different velocity component pairs separated by the height argument
stormuandstormvmight be better asu_stormandv_storm
Collaborator
|
Also, it looks like the argument order swap in |
pressure -> temp -> moisture
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Checklist