Skip to content

Fix Bug#10

Open
gongwen wants to merge 1 commit into
Unity-Technologies:masterfrom
gongwen:v4.4.0-patch1
Open

Fix Bug#10
gongwen wants to merge 1 commit into
Unity-Technologies:masterfrom
gongwen:v4.4.0-patch1

Conversation

@gongwen

@gongwen gongwen commented Sep 12, 2022

Copy link
Copy Markdown

1。The callback of onUnityAdsFailedToLoad and onUnityAdsShowFailure should be dispatched in main thread。
2。Fix the exception escape caused by using ExecutorService.submit。
When using ExecutorService.submit, if it is not handled properly, it may cause an exception to escape. For example: only call the method, but do not handle its exception

The following is the official document introduction:https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/ThreadPoolExecutor.html

Note: When actions are enclosed in tasks (such as FutureTask) either explicitly or via methods such as submit, these task objects catch and maintain computational exceptions, and so they do not cause abrupt termination, and the internal exceptions are not passed to this method.

1。The callback of onUnityAdsFailedToLoad and onUnityAdsShowFailure should be dispatched in main thread。
2。Fix the exception escape caused by using ExecutorService.submit。
@gzjaychen

gzjaychen commented Aug 22, 2024

Copy link
Copy Markdown

@UnitySteven @TinaHanAtUnity
Please check the proguard of android Unity Ads 4.12.2

-keep public class * {
*;
}

It will keep all the classes of the whole project and increase the apk size.

@zhaidw

zhaidw commented Aug 23, 2024

Copy link
Copy Markdown

@UnitySteven @TinaHanAtUnity Please check the proguard of android Unity Ads 4.12.2

-keep public class * { *; }

It will keep all the classes of the whole project and increase the apk size.

Yes, I found same bug for my android not obfuscated by Unity Ads 4.12.2

@Jun19

Jun19 commented Sep 2, 2024

Copy link
Copy Markdown

@UnitySteven @TinaHanAtUnity Please check the proguard of android Unity Ads 4.12.2

-keep public class * { *; }

It will keep all the classes of the whole project and increase the apk size.

fix it plz @DeclanMcPartlin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants