This repository was archived by the owner on Feb 22, 2024. It is now read-only.
feat(api): Refinement around handling of mixed text file / non-text file requests #106#173
Open
kravetsmic wants to merge 4 commits into
Conversation
cragwolfe
suggested changes
May 23, 2023
Contributor
cragwolfe
left a comment
cragwolfe
left a comment
There was a problem hiding this comment.
This isn't actually addressing the ordering issue in #106 .
As a change on its own, I also think this change is too restrictive, and the API is better of being less opiniated. E.g., a file sent with the files parameter could be any mimetype, inclluding text/plain.
on the other hand, in the text_files case, there are quite a few more valid plain text mimetypes floating around out there (e.g. html, xml, ...). so, i think for now it is better not to try to enumerate them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added validation for text files in test API. If the user sends text files to the file endpoint, or files to the text file endpoint, he will get exception from server with message
Type {file_content_type} not supported for files / text files endpoint.and status code 400.Added additional tests.
Closes issue #106