Make get_app lock-free via ETS, run OAuth refresh in Tasks#27
Open
wawashra wants to merge 1 commit into
Open
Conversation
Eliminates GenServer.call timeouts on get_app/1 and refresh stampedes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eliminates GenServer.call timeouts on get_app/1 and refresh stampedes.
Problem
Singleton
SalesforceGenServer did synchronous HTTPS insideinit/handle_call/handle_info, so every tenant's:get_appwas head-of-line-blocked behind OAuth refreshes and timed out at 5s.Fix
Per-app
%{client, config}now lives in a public ETS table →get_app/1is a lock-free:ets.lookup/2. All HTTPS (register, refresh, periodic) runs in unlinked Tasks that write ETS directly and self-schedule the next refresh.Other changes
init/1returns instantly; initial refresh fires fromhandle_continuein parallel. Refresh interval jittered 2h ± 7.5m; errors retry in 5m instead of falling off the schedule. Atom-leak fromString.to_atom(app_token)removed.