remove redeclaration of _onDestroy()#203
Merged
UshakovVasilii merged 1 commit intoUshakovVasilii:masterfrom May 25, 2021
Valent-in:master
Merged
remove redeclaration of _onDestroy()#203UshakovVasilii merged 1 commit intoUshakovVasilii:masterfrom Valent-in:master
UshakovVasilii merged 1 commit intoUshakovVasilii:masterfrom
Valent-in:master
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_onDestroy() is already present in panelMenu.Button
https://github.com/GNOME/gnome-shell/blob/e6089c83e2993098814b7056e1c7f54e5dc06820/js/ui/panelMenu.js#L187
So this function is called twice. Put log("### something") into it to check. And proper Button._onDestroy() is not called at all. This leads to shell crash on screen lock.
Also spaming ~15 lines in journal on extension disable:
I'm not shure which solution is better... Mybe adding super._onDestroy() and removing connection to 'destroy' signal is more propper... But proposed renaming is simple and tested and works ok.