Skip to content

Fix inconsistencies in rank-local SVD wrapper#263

Merged
evaleev merged 4 commits into
ValeevGroup:masterfrom
wavefunction91:dbwy/bugfix/svd
Apr 2, 2021
Merged

Fix inconsistencies in rank-local SVD wrapper#263
evaleev merged 4 commits into
ValeevGroup:masterfrom
wavefunction91:dbwy/bugfix/svd

Conversation

@wavefunction91
Copy link
Copy Markdown

@wavefunction91 wavefunction91 commented Mar 25, 2021

Addresses #262

This PR implements the following changes:

  1. The rank-local SVD wrapper now does the "right" thing viz reallocating U/VT to the right dimensions based on the desired outputs.
  2. Changes the default behaviour to be "SomeVec" as opposed to "AllVec" to coincide with ScaLAPACK APIs
  3. Adds flexibility in the rank-local SVD wrapper to allow for all allowable "Job" types for XGESVD in LAPACK

@evaleev
Copy link
Copy Markdown
Member

evaleev commented Apr 2, 2021

@asadchev please have a look

@evaleev evaleev merged commit 96783eb into ValeevGroup:master Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants