Skip to content

numeric_type trait for Eigen matrices not needed since Eigen 3.3 #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evaleev merged 1 commit into from
Apr 2, 2021
Merged

numeric_type trait for Eigen matrices not needed since Eigen 3.3 #264

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions src/TiledArray/type_traits.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,17 +65,6 @@ inline constexpr bool is_integral_v = is_integral<T>::value;
//////////////////////////////////////////////////////////////////////////////////////////////
// forward declarations

namespace Eigen {

template <typename, int, int, int, int, int>
class Matrix;
template <typename, int, int, int, int, int>
class Array;
template <typename, int, typename>
class Map;

} // namespace Eigen

namespace madness {

template <typename T>
Expand Down Expand Up @@ -736,20 +725,6 @@ struct numeric_type<T, typename std::enable_if<is_lazy_tile<T>::value &&
!is_numeric_v<T>>::type>
: public numeric_type<typename eval_trait<T>::type> {};

template <typename T, int Rows, int Cols, int Opts, int MaxRows, int MaxCols>
struct numeric_type<Eigen::Matrix<T, Rows, Cols, Opts, MaxRows, MaxCols>, void>
: public numeric_type<typename Eigen::Matrix<T, Rows, Cols, Opts, MaxRows,
MaxCols>::Scalar> {};

template <typename T, int Rows, int Cols, int Opts, int MaxRows, int MaxCols>
struct numeric_type<Eigen::Array<T, Rows, Cols, Opts, MaxRows, MaxCols>, void>
: public numeric_type<typename Eigen::Matrix<T, Rows, Cols, Opts, MaxRows,
MaxCols>::Scalar> {};

template <typename PlainObjectType, int MapOptions, typename StrideType>
struct numeric_type<Eigen::Map<PlainObjectType, MapOptions, StrideType>, void>
: public numeric_type<PlainObjectType> {};

/// \c numeric_t<T> is an alias for \c numeric_type<T>::type
template <typename T>
using numeric_t = typename TiledArray::detail::numeric_type<T>::type;
Expand Down