Skip to content

cuda callback is prebuf-aware #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evaleev merged 1 commit into from
May 26, 2021
Merged

cuda callback is prebuf-aware #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/TiledArray/cuda/cuda_task_fn.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,9 @@ struct cudaTaskFn : public TaskInterface {
// std::string message = "callback on cudaTaskFn: " + address.str() +
// '\n'; std::cout << message;
callback->notify();
// must flush the prebuf (if any) to make sure this cleanup task will be
// actually submitted
ThreadPool::instance()->flush_prebuf();
const auto t1 = TiledArray::now();

TiledArray::detail::cuda_taskfn_callback_duration_ns() +=
Expand Down Expand Up @@ -799,10 +802,10 @@ add_cuda_taskfn(
cudaTaskFn<fnT, a1T, a2T, a3T, a4T, a5T, a6T, a7T, a8T, a9T>* t) {
typename cudaTaskFn<fnT, a1T, a2T, a3T, a4T, a5T, a6T, a7T, a8T, a9T>::futureT
res(t->result());
// add the cuda task
world.taskq.add(static_cast<TaskInterface*>(t));
// add the internal async task in cuda task as well
world.taskq.add(t->async_task());
// add the cuda task
world.taskq.add(static_cast<TaskInterface*>(t));
return res;
}

Expand Down