Fix the path for MADNESS config.h#293
Merged
Merged
Conversation
This is required when MADNESS_ROOT_DIR is set.
Member
|
@keceli MADNESS_DIR should be the location of madness-config, not location of the source directory ... what's the issue you are seeing when using externally-installed MADNESS? |
Contributor
Author
|
When I set |
Member
|
you should install MADNESS first, then list its install prefix in
CMAKE_PREFIX_PATH e.g.
-DCMAKE_PREFIX_PATH=/path/to/package/1;/path/to/package/2;....
…On Thu, Jul 8, 2021 at 12:51 PM keceli ***@***.***> wrote:
When I set MADNESS_ROOT_DIR to the path of madness-build, I get did not
find MADNESS' config.h error. This fixes the problem. If this is not
right, what is the correct way of specifying the location of an external
madness build?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#293 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQXIZ6MDS43RO4SX7JTQCTTWXJSJANCNFSM5ABC7W3Q>
.
--
web: valeyev.net
|
Contributor
Author
|
Thank you Ed, that works. This PR could be useful only if a user built MADNESS, but not installed. So, please close it if you think that is not important. |
Member
|
MADNESS targets are technically usable from the build tree (i.e.
find_project(MADNESS...) will work even if MADNESS is not installed). I
don't think it's a common use case, but in principle the changes needed to
support it are minor so I don't see a reason to not support it.
…On Thu, Jul 8, 2021 at 5:05 PM keceli ***@***.***> wrote:
Thank you Ed, that works. This PR could be useful only if a user built
MADNESS, but not installed. So, please close it if you think that is not
important.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#293 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAQXIZ4KIN3RWTZWCZK5RNTTWYHJ5ANCNFSM5ABC7W3Q>
.
--
web: valeyev.net
|
so that MADNESS_ROOT_DIR can be set to MADNESS install directory or build directory
evaleev
force-pushed
the
fix_CONFIG_H_PATH
branch
from
4fcdcb1 to
66095d1
Compare
evaleev
approved these changes
Jul 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required when MADNESS_ROOT_DIR is set. With the old path I got
did not find MADNESS' config.h.