[HL2MP] Fix incorrect scrape sound#1008
Closed
speedvoltage wants to merge 1 commit into
Closed
Conversation
► Fixed an issue where the scrape rough sound would sometimes play for no reason.
Contributor
|
Duplicate of #441 ? |
Contributor
Author
I will defer this to @kisak-valve to conclude if this is a duplicate PR. I forgot there was already a PR for this but it was made before the SDK was updated. |
Member
|
Hello, yes, functionally this looks like a duplicate. Closing in favor of the older pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
There is an incorrect use of the scrape rough sound, which sometimes lead to the sound being looped until
snd_restartis used.Fix:
Switch the sound to
scrapeSmooth.