fix: Fix the sandman voice lines not playing.#984
Open
Trico-Everfire wants to merge 2 commits into
Open
Conversation
…lance change involving the removal of TF_STUN_CONTROLS
skmedix
reviewed
Mar 11, 2025
Co-authored-by: skmedix <3246162+skmedix@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Scout has voice lines related to stunning another player with the sandman ball.
These lines no longer trigger as Scout no longer stuns the enemy player's controls which it was specifically checked for. This was originally triggered by tf_player_shared.cpp's StunPlayer function. The trigger for the voice lines has now been moved into the
ApplyBallImpactEffectOnVictimfunction to not break any existing logic related to the original StunPlayer function.2025-03-10.22-37-43.1.mp4
2025-03-10.20-31-12.mp4
This would fix issue:
ValveSoftware/Source-1-Games#4467