Inherent weight miscalculation in Inventory + module

[Dialectikal]

Environment Details

• Foundry VTT Version: 0.8.9
• Operating System: Windows 10
• How Are You Using Foundry: Chrome
• Which Game System: dnd5e
• Modules Enabled?: yes [Inventory+, Item Containers, libWrapper, Variant Encumbrance]

Issue Description

There is currently a calculation issue with this module and the Inventory+ module.
With Inventory+ there is an Inherent Weight option on each inventory category:

This option is intended to simulate the weight of a container item which represents that particular category. For instance, if I have a backpack that weighs 30 lbs, then I can set the Inherent Weight equal to 30. This will in turn increase my total carry weight or encumbrance by exactly 30. This is how the property works without the Variant Encumbrance module installed.

By contrast, the Variant Encumbrance module effectively changes this property, setting it to increase by the entered value for every single item contained within that particular category.

[p4535992]

Ty very much for this detailed ticket.
Should be fixed with 0.5.19.
Try it out.

[Dialectikal]

There is still a strange calculation going on with this.

Here you can see the Inherent Weight is set to 0:

And here you can see I've increased it by 1:

This should only increase the total encumbrance by exactly 1, but it appears to be increasing by 3.6.
I can't immediately tell where this value is derived from, but it seems to be multiplied by the items contained within a particular category.

[VanirDev]

I've got some suspicions over what this is being caused by in the code, I've made a new branch and asked for clarification from @p4535992 on what some specific elements are intended for to make sure I'm not misunderstanding it. Should be a pretty quick fix once that's cleared up.

[Dialectikal]

@p4535992 Just a reminder this is still out there. Wasn't sure if you had seen it.

[p4535992]

Try out 0.5.21 and let me know.

[p4535992]

it's this error still persist on 0.6.5 version ?

[p4535992]

I wil close this issue because i think is solved

[DanielTheBard]

Pretty sure it's still not working.

Here is an my player's inventory w/ a backpack category from Inventory+ and the standard weight calculation turned on (it's seemingly correct at 66 lb. outside of ignoring the Inherent Weight value entirely)

With your weight calculation turned on (and all the equipped modifiers still set at the default 1), total weight drops by 16 lbs to 50 lbs. Is this intentional behavior? If I adjust the inherent weight by any number, the total moves to reflect by the same amount. If

Unless I change the Inherent Weight to 0, then it jumps up to 71 lbs. (ironically the correct total weight when including the weight of the backpack)

If this is intended behavior, some transparency on what's being calculated here would be helpful. I have no multipliers set for if something is equipped or unequipped, but putting items into an Inventory+ category w/ an inherent weight, lowers the total weight. If it has no inherent weight, moving items in/out of the category, has 0 effect on total weight, and instead has added about 5 unaccounted for extra lbs.

[p4535992]

can you pass me the json of the actor are you using so i can try to replicate the use case ?

[DanielTheBard]

fvtt-Actor-zruggig-widebrain.zip

I think I see what's happening now though. I think the weigh calculation is just taking whatever I put for the inherent weight (other than 0), and ignoring every item's weight in the category, regardless of whether I've checked off the "Ignore Item Weight" button.

[DanielTheBard]

Just realized I'd since added a bag of holding category to that sheet once you'd asked for it. (edit: if you delete the items from the bag of holding, it should be the same as what I screenshotted I think)