Merged
Conversation
Workaround for issue where model_dump_json picks an IRI rather than a SequenceLocation to represent an Allele or Haplotype's location.
bencap
approved these changes
Aug 9, 2024
| post_mapped_2_0=post_mapped, | ||
| pre_mapped=pre_mapped, | ||
| post_mapped=post_mapped, | ||
| vrs_version=vrs_version, # TODO figure out how inserting an enum value works |
Remove cli boolean flag that allowed for inclusion of v2 in addition to v1.3
sallybg
force-pushed
the
improve-vrs-2-output
branch
from
6a499fc to
8b2b75e
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide expanded VRS 2 output which includes detailed location information.
Instead of providing a CLI option to include VRS 2 output in addition to VRS 1.3,
provide a CLI option to include either VRS 1.3 or VRS 2 output.
Make VRS 2 the default output.