Debug statistics record score-set and keywords problem.#278
Merged
EstelleDa merged 2 commits intorelease-2024.3.1from Aug 30, 2024
Merged
Debug statistics record score-set and keywords problem.#278EstelleDa merged 2 commits intorelease-2024.3.1from
EstelleDa merged 2 commits intorelease-2024.3.1from
Conversation
bencap
approved these changes
Aug 29, 2024
Collaborator
bencap
left a comment
bencap
left a comment
There was a problem hiding this comment.
Thanks for keeping an eye on the alerts channel Estelle, I appreciate it. If you can just remove the print statements before merging this looks good.
| model_created_by_field = getattr(queried_model, "created_by_id") | ||
| model_published_data_field = getattr(queried_model, "published_date") | ||
| if field is RecordFields.createdBy: | ||
| print("111") |
Collaborator
There was a problem hiding this comment.
Suggested change
| print("111") |
Member
Author
There was a problem hiding this comment.
oops. Totally forgot them. Thanks Ben!
|
|
||
| return db.execute(query).all() | ||
| else: | ||
| print("2222") |
Collaborator
There was a problem hiding this comment.
Suggested change
| print("2222") |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model options are from Class RecordNames(experiment and score-set) and fields options are from Class RecordFields(publication-identifiers, keywords, doi-identifiers, raw-read-identifiers and created-by).
However, score-set doesn't have keywords anymore. Hence, adding a validator to handle this case.