Allow downloads of VA-Spec objects from variant pages#588
Merged
bencap merged 4 commits intorelease-2025.5.3from Dec 18, 2025
Merged
Conversation
sallybg
approved these changes
Dec 2, 2025
Contributor
sallybg
left a comment
There was a problem hiding this comment.
This looks great! One thought is whether we want to provide a more detailed error message if the annotation can't be downloaded due to a missing mapped variant in the database. I think it can be confusing to get a "not found" error message and not know whether it's your browser, your login information, or if we're simply missing the info on our side. (Hopefully we won't be missing data on our side, but it could happen since we allow publication with mapping errors.) Or maybe we could consider not showing or greying out the button if there is no mapped variant available for the selected variant, but maybe that's more confusing.
So long as variant names in a list are the same (excluding null and undefined names), we will use them as the variant header
f56d551 to
d9b4c71
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
VariantScreen.vuecomponent by adding a feature to download annotations for the selected variant. It introduces a newSplitButtonin the header, allowing users to choose from multiple annotation types to download as JSON files. The implementation includes new computed properties and a method for fetching and downloading the annotation data, as well as UI improvements for better usability.Feature: Download Variant Annotations
SplitButtonto the variant header that enables users to download different types of annotations (clinical evidence, functional impact statement, study result) for the currently selected variant. The button dynamically updates its options based on the available data for the active variant. [1] [2] [3]Implementation Details
annotatedVariantDownloadOptionsto generate the download menu options based on the active variant's data.fetchVariantAnnotationsmethod, which retrieves the requested annotation from the API and triggers a JSON file download in the browser. Error handling is included to notify the user if the download fails.UI and Code Quality Improvements