Fix list_index variable shadowing in fix_incorrect_toc - #167
Merged
Conversation
The loop variable `list_index = page_index - start_index` was overwriting the outer `list_index = incorrect_item['list_index']`, causing results to be written back to wrong index positions. Rename the loop variable to `page_list_idx` to avoid shadowing. Closes #66
martindecz
pushed a commit
to martindecz/PageIndex
that referenced
this pull request
Mar 29, 2026
- Upstream main (28542de) — latest VectifyAI/PageIndex - PR VectifyAI#188: fix prevent KeyError crash and context exhaustion in TOC processing - Fix list_index shadowing (VectifyAI#167) already in upstream - LiteLLM integration (VectifyAI#168) already in upstream Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
martindecz
pushed a commit
to martindecz/PageIndex
that referenced
this pull request
Apr 11, 2026
…ectifyAI#167) Rename loop variable list_index -> page_list_idx to prevent overwriting outer list_index = incorrect_item['list_index'], which caused results to be written back to wrong index positions. Cherry-picked from VectifyAI/PageIndex@85f17f9 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
suulkyy
pushed a commit
to suulkyy/PageIndex
that referenced
this pull request
May 8, 2026
Fix list_index variable shadowing in fix_incorrect_toc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
list_indextopage_list_idxinfix_incorrect_tocto avoid shadowing the outerlist_index = incorrect_item['list_index'], which caused results to be written back to wrong index positions.Closes #66