fix: guard get_leaf_nodes, page offset, and process_none_page_numbers against missing keys - #350
Closed
fooSynaptic wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #330, #153, #97
.get('nodes')— leaf nodes fromlist_to_treehave nonodeskey (Bug:get_leaf_nodesraises KeyError on leaf nodes due to missingnodeskey #330 regression after Adds missing re import #281)calculate_page_offsetreturns None (Unsupported operand type(s) for +: 'int' and 'NoneType' #153)pop('page', None)instead ofdel(process_none_page_numbers raises KeyError when 'page' is missing #97)Includes regression tests in
tests/test_issue_330_153_97.py(6 passed locally).Test plan
pytest tests/test_issue_330_153_97.py -v— 6 passed