fix: make ChatGPT_API_with_finish_reason return consistent tuple - #63
Merged
Merged
Conversation
Signed-off-by: luojiyin <luojiyin@hotmail.com>
Member
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. The fix correctly addresses the inconsistent return type: all callers use 馃 Generated with Claude Code - If this code review was useful, please react with 馃憤. Otherwise, react with 馃憥. |
BukeLy
approved these changes
Mar 16, 2026
3 tasks
suulkyy
pushed a commit
to suulkyy/PageIndex
that referenced
this pull request
May 8, 2026
fix: make ChatGPT_API_with_finish_reason return consistent tuple
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #62 - Make
ChatGPT_API_with_finish_reasonreturn consistent tuple type on error.Problem
The function returned
(content, finish_reason)on success but"Error"string when max retries reached, causing unpacking errors.Change
("", "error")tuple instead of"Error"stringTest
Manual testing of error scenarios.