fix(app): make linux CEF deb package runnable#3
Open
VectorJet wants to merge 3 commits intoswitch-to-pnpmfrom
Open
fix(app): make linux CEF deb package runnable#3VectorJet wants to merge 3 commits intoswitch-to-pnpmfrom
VectorJet wants to merge 3 commits intoswitch-to-pnpmfrom
Conversation
Add comprehensive unit tests for PR #3 changes: - default_core_bin() tests: * Env override takes precedence when file exists * Graceful handling when env override points to nonexistent file * Symlink resolution for same_executable_path * Nonexistent file handling * Core process handle creation and RPC URL formatting - setup_tray() tests: * Conditional compilation validation * Dictation shortcut expansion (CmdOrCtrl handling) * Platform-specific behavior (macOS vs non-macOS) - Additional helper tests: * is_daemon_mode detection * core_rpc_url() with env var and fallback * overlay_parent_rpc_url() edge cases (empty, whitespace) These tests verify the grep-friendly logging patterns and packaged Linux binary path probing introduced in the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.debinstalls without hand-editingDEBIAN/controlopenhuman-corefrom Linux install locations like/usr/bin/openhuman-corelinux + cefbuilds to avoid the packaged GTK panic during tray/menu creationProblem
.debwas not runnable after install on Debian 13 / trixielibwebkit2gtk-4.0-37,libgdk-pixbuf2.0-0)openhuman-corenext to the app binary/resources, but the.debinstalls it in/usr/binSolution
tauri.conf.jsonLinux deb dependencies to trixie package namesdefault_core_bin()to probe packaged Linux locations before falling back to sibling/resource lookupsetup_tray()by cfg and short-circuit tray creation onlinux + cefwith an explicit warning logRunEvent::Readytray deferral for other targets/runtime combinationsSubmission Checklist
app/) and/orcargo test(core) for logic you add or changeapp/test/e2e, mock backend,tests/json_rpc_e2e.rsas appropriate)cargo check --manifest-path src-tauri/Cargo.toml --target aarch64-unknown-linux-gnuplus a local packaged install reproImpact
.debartifactslinux + cefpath; tray behavior on other targets is unchangedRelated
chrome-sandboxpermissions automatically