Skip to content

feat: update prime note & pagination - #5756

Merged
cuzz-venus merged 11 commits into
mainfrom
feat/prime
Jul 31, 2026
Merged

feat: update prime note & pagination#5756
cuzz-venus merged 11 commits into
mainfrom
feat/prime

Conversation

@cuzz-venus

@cuzz-venus cuzz-venus commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Jira ticket(s)

VPD-1720
VPD-1719

Changes

  • update prime refresh note & pagination
2026-07-30.20.50.58.mov

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dapp-preview Ready Ready Preview Jul 31, 2026 6:30am
dapp-testnet Ready Ready Preview Jul 31, 2026 6:30am
venus.io Ready Ready Preview Jul 31, 2026 6:30am

Request Review

@changeset-bot

changeset-bot Bot commented Jul 30, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8c38b0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@venusprotocol/evm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment thread apps/evm/src/pages/PrimeLeaderboard/RefreshNote/index.tsx Outdated
@greptile-apps

greptile-apps Bot commented Jul 30, 2026

Copy link
Copy Markdown

Greptile Summary

The PR redesigns pagination and expands the Prime leaderboard refresh notice.

  • Replaces numbered pagination controls with an editable current-page field and navigation buttons.
  • Resets Dashboard pagination when the selected chain changes.
  • Adds localized Prime cutoff information and updates leaderboard action styling and tests.

Confidence Score: 4/5

The PR is not yet safe to merge because the cutoff note can display stale minimum-stake values under a newer leaderboard refresh timestamp.

The original score-versus-stake mismatch is fixed by sourcing both values from the minimum-stake response, but the displayed timestamp still comes from the independently and more frequently refreshed leaderboard response, so the note can continue presenting different snapshots as one state.

Files Needing Attention: apps/evm/src/pages/PrimeLeaderboard/RefreshNote/index.tsx

Important Files Changed

Filename Overview
apps/evm/src/pages/PrimeLeaderboard/RefreshNote/index.tsx Adds the Prime cutoff score and stake, but combines them with a refresh timestamp from an independently refreshed response.
apps/evm/src/components/Pagination/index.tsx Replaces numbered page links with a validated editable page input and first, previous, next, and last controls.
apps/evm/src/components/Pagination/usePagination.ts Removes numbered-page window calculation while preserving URL synchronization and page navigation.
apps/evm/src/pages/Dashboard/index.tsx Clears the default pagination query parameter when the active chain changes.
apps/evm/src/pages/PrimeLeaderboard/RankActions/index.tsx Adjusts the rank-card action layout to keep both buttons within equal-width columns.

Reviews (2): Last reviewed commit: "feat: update data source" | Re-trigger Greptile

@cuzz-venus

Copy link
Copy Markdown
Contributor Author

@greptile review again

Comment thread apps/evm/src/pages/PrimeLeaderboard/RefreshNote/index.tsx
@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 77.81% 50186 / 64490
🔵 Statements 77.81% 50186 / 64490
🔵 Functions 72.5% 1532 / 2113
🔵 Branches 85.13% 7306 / 8582
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/evm/src/components/Pagination/index.tsx 67.18% 80% 18.18% 67.18% 60-61, 88-106, 109-116, 119-125, 132-137, 141-146
apps/evm/src/components/Pagination/styles.ts 100% 100% 100% 100%
apps/evm/src/components/Pagination/usePagination.ts 73.68% 91.66% 33.33% 73.68% 43-50, 63-71
apps/evm/src/pages/Dashboard/index.tsx 80.39% 37.5% 100% 80.39% 32-37, 84-89, 92-97, 102-103
apps/evm/src/pages/PrimeLeaderboard/PrimeLeaderboardTable/index.tsx 100% 100% 100% 100%
apps/evm/src/pages/PrimeLeaderboard/RankCard/RankActions/index.tsx 100% 33.33% 20% 100%
apps/evm/src/pages/PrimeLeaderboard/RankTable/index.tsx 95.14% 71.42% 80% 95.14% 38, 86, 118-120
apps/evm/src/pages/PrimeLeaderboard/RefreshNote/index.tsx 98.48% 90.9% 100% 98.48% 69
Generated in workflow #14002 for commit 8c38b0a by the Vitest Coverage Report Action

@cuzz-venus
cuzz-venus requested a review from therealemjy July 31, 2026 06:49
Comment thread apps/evm/src/components/Pagination/index.tsx
Comment thread apps/evm/src/components/Pagination/index.tsx
@cuzz-venus
cuzz-venus merged commit f079bf7 into main Jul 31, 2026
5 checks passed
@cuzz-venus
cuzz-venus deleted the feat/prime branch July 31, 2026 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants