Skip to content

fix: various fixes - #5759

Merged
therealemjy merged 1 commit into
mainfrom
fix/various-fixes
Aug 3, 2026
Merged

fix: various fixes#5759
therealemjy merged 1 commit into
mainfrom
fix/various-fixes

Conversation

@therealemjy

Copy link
Copy Markdown
Member

Changes

  • Fixed E-Mode group sorting so blocked groups are correctly pushed after enableable groups
  • Added unit tests covering E-Mode sorting behavior
  • Updated pending rewards query key to include isolated pool comptroller addresses and fixed the XVS vault pool count query enablement logic
  • Removed duplicate API exports
  • Updated the format script to use the workspace Biome dependency and added Biome as a dev dependency

@therealemjy
therealemjy requested a review from cuzz-venus August 1, 2026 19:58
@changeset-bot

changeset-bot Bot commented Aug 1, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e03229c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@venusprotocol/evm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Aug 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dapp-preview Ready Ready Preview Aug 1, 2026 8:04pm
dapp-testnet Ready Ready Preview Aug 1, 2026 8:04pm
venus.io Ready Ready Preview Aug 1, 2026 8:04pm

Request Review

@greptile-apps

greptile-apps Bot commented Aug 1, 2026

Copy link
Copy Markdown

Greptile Summary

This PR applies several focused fixes across E-Mode ordering, pending-rewards caching and query enablement, API exports, and formatting dependencies.

  • Corrects E-Mode sorting and adds unit coverage for enableable and blocked groups.
  • Includes isolated-pool comptroller addresses in the pending-rewards query key.
  • Enables the XVS vault pool-count query by default unless explicitly disabled.
  • Removes duplicate exports and uses the workspace Biome dependency.
  • Synchronizes the root lockfile entry with the added Biome dependency.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the previously stale root lockfile entry now includes the newly declared Biome dependency.

Important Files Changed

Filename Overview
package.json Uses the workspace Biome binary and declares the corresponding development dependency.
yarn.lock Adds the Biome dependency to the root workspace entry, resolving the previously reported immutable-install failure.
apps/evm/src/clients/api/queries/getPendingRewards/useGetPendingRewards.ts Expands pending-rewards cache identity with sorted isolated-pool addresses and corrects default query enablement.
apps/evm/src/containers/EModeGroupList/formatEModeGroups/index.ts Corrects the second group's enableability calculation so blocked groups sort after enableable groups.
apps/evm/src/containers/EModeGroupList/formatEModeGroups/tests/index.spec.ts Adds coverage for enabled, enableable, and blocked E-Mode group ordering.

Reviews (2): Last reviewed commit: "fix: various fixes" | Re-trigger Greptile

Comment thread package.json

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4199484a13

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread package.json
@therealemjy

Copy link
Copy Markdown
Member Author

@greptile

@github-actions

github-actions Bot commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 77.83% 50196 / 64493
🔵 Statements 77.83% 50196 / 64493
🔵 Functions 72.5% 1532 / 2113
🔵 Branches 85.21% 7318 / 8588
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/evm/src/clients/api/index.ts 100% 100% 100% 100%
apps/evm/src/clients/api/queries/getPendingRewards/useGetPendingRewards.ts 59.71% 70% 33.33% 59.71% 84, 102-141, 172-193
apps/evm/src/containers/EModeGroupList/formatEModeGroups/index.ts 98.43% 95.34% 100% 98.43% 134-135
Generated in workflow #14012 for commit e03229c by the Vitest Coverage Report Action

@cuzz-venus cuzz-venus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therealemjy
therealemjy merged commit d9afa6c into main Aug 3, 2026
5 checks passed
@therealemjy
therealemjy deleted the fix/various-fixes branch August 3, 2026 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants