Skip to content

ci: increase test coverage - #5760

Merged
therealemjy merged 1 commit into
mainfrom
ci/test-coverage
Aug 3, 2026
Merged

ci: increase test coverage#5760
therealemjy merged 1 commit into
mainfrom
ci/test-coverage

Conversation

@therealemjy

Copy link
Copy Markdown
Member

Changes

  • increase overall test coverage by adding tests for large blocks that didn't have any

@therealemjy
therealemjy requested a review from cuzz-venus August 3, 2026 09:44
@changeset-bot

changeset-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 535b30c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dapp-preview Ready Ready Preview Aug 3, 2026 10:51am
dapp-testnet Ready Ready Preview Aug 3, 2026 10:51am
venus.io Ready Ready Preview Aug 3, 2026 10:51am

Request Review

@greptile-apps

greptile-apps Bot commented Aug 3, 2026

Copy link
Copy Markdown

Greptile Summary

The PR substantially expands Vitest and Testing Library coverage for routing, layout, dashboard, API formatting, Prime estimation, and vault UI flows.

  • Adds route, redirect, layout, header, footer, performance-chart, and summary tests.
  • Adds shared Pendle vault fixtures and broader deposit, withdrawal, overview, and vault-card coverage.
  • Prevents the Dashboard summary from displaying the minted-VAI cell when the aggregated balance is zero.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete blocking or independently actionable non-blocking defects identified.

The only production change explicitly checks that the aggregated minted-VAI BigNumber is positive, matching the added zero-balance test, while the remaining changes expand test coverage and fixtures without establishing a broken runtime or CI contract.

Important Files Changed

Filename Overview
apps/evm/src/pages/Dashboard/Summary/index.tsx Replaces a BigNumber truthiness check with an explicit positive-balance check, correctly suppressing the minted-VAI cell at zero.
apps/evm/src/pages/Dashboard/Summary/tests/index.spec.tsx Adds coverage for summary values, styling, tooltips, optional vault stake, and zero VAI borrow behavior.
apps/evm/src/App/Routes/tests/index.spec.tsx Adds broad coverage for static and feature-gated routes, legacy redirects, scrolling, and the Discord redirect.
apps/evm/src/mocks/models/vaults.ts Adds reusable Pendle fixtures used by the expanded vault component tests.
apps/evm/src/pages/Dashboard/PerformanceChart/tests/index.spec.tsx Adds coverage for chart rendering and dashboard performance states.
apps/evm/src/clients/api/queries/useGetPrimeEstimation/tests/index.spec.tsx Covers child-query parameters, disabled states, missing accounts and markets, and computed Prime estimation values.

Reviews (1): Last reviewed commit: "ci: increase test coverage" | Re-trigger Greptile

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 80.88% 52165 / 64496
🔵 Statements 80.88% 52165 / 64496
🔵 Functions 74.54% 1587 / 2129
🔵 Branches 86.19% 7631 / 8853
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/evm/src/clients/api/queries/getPendingRewards/index.ts 93.62% 66.66% 100% 93.62% 44-48, 58, 65, 73, 201, 220-221, 239, 262-263, 274-275
apps/evm/src/pages/Dashboard/Summary/index.tsx 100% 100% 100% 100%
Generated in workflow #14018 for commit 535b30c by the Vitest Coverage Report Action

@cuzz-venus cuzz-venus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants