Fix compact output crash on empty received#475
Merged
Conversation
When the received text is empty the diff is all deletions, so every
DiffPiece.Position is null and Max(_ => _.Position) is null. That made
prefixLength 0 and `new string(' ', prefixLength - 1)` throw
ArgumentOutOfRangeException.
Verify invokes the string comparer before writing the received file, so
the throw suppressed the .received.txt entirely and surfaced as "no
output generated" (#474).
Fall back to a single-digit width when there are no positioned lines, and
add a regression test covering an all-deletion diff.
This was referenced Jul 14, 2026
Closed
This was referenced Jul 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.