Allow a stream target for a text extension - #1810
Merged
Merged
Conversation
Since conversion splitters were allowed for text extensions (#1778), a converter registered against a text extension could still not re-emit its source: the Target stream constructor threw for text extensions. eg Verify.ImageMagick returns the svg alongside the rendered png. The stream is now read as text, applying the same newline fixing already used when a stream is read into a text target.
This was referenced Jul 21, 2026
This was referenced Jul 27, 2026
Open
legrab
added a commit
to legrab/pocok
that referenced
this pull request
Jul 29, 2026
Updated [Verify.NUnit](https://github.com/VerifyTests/Verify) from 31.26.0 to 31.27.0. <details> <summary>Release notes</summary> _Sourced from [Verify.NUnit's releases](https://github.com/VerifyTests/Verify/releases)._ ## 31.27.0 - [x] [#1809](VerifyTests/Verify#1809) Emit received→verified mapping for out-of-process accept/review tooling - [x] [#1810](VerifyTests/Verify#1810) Allow a stream target for a text extension - [x] [#1812](VerifyTests/Verify#1812) Received map file Commits viewable in [compare view](VerifyTests/Verify@31.26.0...31.27.0). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since conversion splitters were allowed for text extensions (#1778), a converter registered against a text extension could still not re-emit its source: the Target stream constructor threw for text extensions. eg Verify.ImageMagick returns the svg alongside the rendered png.
The stream is now read as text, applying the same newline fixing already used when a stream is read into a text target.