Conversation
felangel
suggested changes
Jul 15, 2021
Contributor
felangel
left a comment
felangel
left a comment
There was a problem hiding this comment.
Before this can be merged we will need to update the template to support dynamic length for org name parts.
felangel
reviewed
Jul 15, 2021
felangel
approved these changes
Jul 16, 2021
ahsanf
pushed a commit
to Arkabyte-Teknologi/very_good_cli
that referenced
this pull request
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When trying to use the new
--org-namesupport I found that underscores were not being supported. After looking a little closer, the regex for the org name was incorrect by not enforcing that segments must start with a letter and by enforcing a min/max of three segments.I updated the org name regex, invalid org error message, and added more tests for edge cases.
Sources:
Type of Change