Skip to content

fix: org name validation #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felangel merged 8 commits into from
Jul 16, 2021
Merged

fix: org name validation #151

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
20f3409
fix: org name validation
Kirpal Jul 15, 2021
86ad5a5
support hyphen characters in the org name
Kirpal Jul 15, 2021
6ae7b74
formatting
Kirpal Jul 15, 2021
cad1fa0
analyzer
Kirpal Jul 15, 2021
50cd4a2
org_name var format adjustments
felangel Jul 16, 2021
afe3736
revert bundle
felangel Jul 16, 2021
d5297e0
simplify tests
felangel Jul 16, 2021
af879b2
fixes
felangel Jul 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
org_name var format adjustments
  • Loading branch information
@felangel
felangel committed Jul 16, 2021
commit 50cd4a29e659fce68fe5fa76400f82c133f2d056
14 changes: 9 additions & 5 deletions lib/src/commands/create.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,16 @@ class CreateCommand extends Command<int> {
}

/// Gets the organization name.
List<String> get _orgName {
if (_argResults['org-name'] == null) return _defaultOrgName.split('.');

final orgName = _argResults['org-name'] as String;
List<Map<String, String>> get _orgName {
final orgName = _argResults['org-name'] as String? ?? _defaultOrgName;
_validateOrgName(orgName);
return orgName.split('.');
final segments = orgName.replaceAll(RegExp(r'-|_'), ' ').split('.');
return segments.map((segment) {
return {
'value': segment,
'separator': segment == segments.last ? '' : '.'
};
}).toList();
}

void _validateOrgName(String name) {
Expand Down
Loading