Skip to content

feat!: adding publishable flag #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erickzanardo merged 9 commits into from
Dec 6, 2022
Merged

feat!: adding publishable flag #592

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
04eba66
feat: adding publishable flag
erickzanardo Dec 1, 2022
66e7b33
Merge branch 'main' into feat/publishable
erickzanardo Dec 5, 2022
36b0dca
fix: lint
erickzanardo Dec 5, 2022
1a9db6b
fix: test
erickzanardo Dec 5, 2022
8665f46
applying code review
erickzanardo Dec 6, 2022
338795a
fixing tests
erickzanardo Dec 6, 2022
8daf523
fixing tests
erickzanardo Dec 6, 2022
ec8ddf2
PR suggestion and updating bundles
erickzanardo Dec 6, 2022
1f35814
pr suggestions
erickzanardo Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixing tests
  • Loading branch information
@erickzanardo
erickzanardo committed Dec 6, 2022
commit 338795ae3b60ec4a0cfbb059e848372958bbbf6c
4 changes: 2 additions & 2 deletions lib/src/commands/create/create.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ class CreateCommand extends Command<int> {
final executableName =
_argResults['executable-name'] as String? ?? projectName;
final applicationId = _argResults['application-id'] as String?;
final publishable = _argResults['publishable'] as String?;
final publishable = _argResults['publishable'] as bool;
var vars = <String, dynamic>{
'project_name': projectName,
'description': description,
Expand All @@ -186,7 +186,7 @@ class CreateCommand extends Command<int> {
if (macos.toBool()) 'macos',
if (windows.toBool()) 'windows',
],
if (publishable != null) 'publishable': publishable == 'true',
if (publishable) 'publishable': publishable,
};
await generator.hooks.preGen(vars: vars, onVarsChanged: (v) => vars = v);
final target = DirectoryGeneratorTarget(outputDirectory);
Expand Down