refactor: add visibleForTesting annotations to testing-related parameters#823
Merged
renancaraujo merged 7 commits intoVeryGoodOpenSource:mainfrom Oct 2, 2023
Conversation
superiorsd10
requested review from
erickzanardo,
felangel,
renancaraujo and
wolfenrain
as code owners
renancaraujo
reviewed
Oct 2, 2023
lib/src/commands/update.dart
Outdated
| UpdateCommand({ | ||
| required Logger logger, | ||
| PubUpdater? pubUpdater, | ||
| @visibleForTesting PubUpdater? pubUpdater, |
Contributor
There was a problem hiding this comment.
Is this for test only?
Contributor
Author
There was a problem hiding this comment.
Oops, I've realized my mistake. Sorry, I'll be making the required changes now.
lib/src/commands/packages.dart
Outdated
| class PackagesCommand extends Command<int> { | ||
| /// {@macro packages_command} | ||
| PackagesCommand({Logger? logger}) { | ||
| PackagesCommand({@visibleForTesting Logger? logger}) { |
Contributor
There was a problem hiding this comment.
Is this for test only?
Contributor
Author
There was a problem hiding this comment.
Oops, I've realized my mistake. Sorry, I'll be making the required changes now.
…r in command_runner.dart file
superiorsd10
force-pushed
the
visible-for-testing-annotation
branch
from
0e091b3 to
5cba1de
Compare
renancaraujo
approved these changes
Oct 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Throughout the codebase, there are instances where classes have optional parameters designed for dependency injection during testing. This PR adds visibleForTesting annotations to explicitly mark these parameters for testing purposes.
Resolves #761
Type of Change