Skip to content

refactor: make all mock class to private#838

Merged
alestiago merged 5 commits intoVeryGoodOpenSource:mainfrom
droidbg:mock_class_to_private
Oct 6, 2023
Merged

refactor: make all mock class to private#838
alestiago merged 5 commits intoVeryGoodOpenSource:mainfrom
droidbg:mock_class_to_private

Conversation

@droidbg
Copy link
Contributor

@droidbg droidbg commented Oct 4, 2023

Description

I've updated all the mock classes presented in the code, changing them from public to private mocks.

Private Mocks are useful for a few reasons:

  1. They make it clear that they should only be used in that specific test file.
  2. They help keep the test file tidy and self-contained, so it doesn't rely on stuff from other test files.
  3. They prevent accidental use in the wrong places.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Related Tickets & Documents

@droidbg droidbg requested a review from alestiago as a code owner October 4, 2023 16:28
Copy link
Contributor

@renancaraujo renancaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀🚀

@alestiago alestiago merged commit 28e0032 into VeryGoodOpenSource:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor: all Mocks should be private

3 participants