Skip to content

Common labels#2097

Merged
AndrewChubatiuk merged 13 commits into
masterfrom
commonLabels
May 20, 2026
Merged

Common labels#2097
AndrewChubatiuk merged 13 commits into
masterfrom
commonLabels

Conversation

@vrutkovs
Copy link
Copy Markdown
Collaborator

@vrutkovs vrutkovs commented Apr 23, 2026

This ensures HTTPRoutes and PVCs include ManagedMetadata labels and annotations.

Fixes #2094

TODO:

  • Implement passing commonLabel/managedMetadata in pod templates too

Comment thread api/operator/v1beta1/vmcluster_types_test.go Outdated
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 34 files

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.

Comment thread internal/config/config.go Outdated
Copy link
Copy Markdown
Contributor

@AndrewChubatiuk AndrewChubatiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! could you please also add test to cover an attempt to overwrite standard labels using commonLabels?

@vrutkovs vrutkovs force-pushed the commonLabels branch 3 times, most recently from 924233b to f73fcc1 Compare April 23, 2026 19:25
Comment thread internal/controller/operator/factory/build/defaults.go
@vrutkovs vrutkovs force-pushed the commonLabels branch 2 times, most recently from 29cfe5b to 19e5bb8 Compare May 11, 2026 12:20
Comment thread internal/controller/operator/factory/build/httproute.go Outdated
Comment thread internal/controller/operator/factory/vlsingle/vlsingle.go
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 issues found across 17 files (changes from recent commits).

Tip: Review your code locally with the cubic CLI to iterate faster.

Fix all with cubic | Re-trigger cubic

Comment thread internal/controller/operator/factory/vtsingle/vtsingle_test.go
Comment thread internal/controller/operator/factory/vtsingle/vtsingle_test.go
@AndrewChubatiuk AndrewChubatiuk merged commit 4464b15 into master May 20, 2026
6 checks passed
@AndrewChubatiuk AndrewChubatiuk deleted the commonLabels branch May 20, 2026 15:14
@AndrewChubatiuk
Copy link
Copy Markdown
Contributor

@vrutkovs
Thanks for a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

commonLabels and commonAnnotations

2 participants