e2e: removed validating job#2174
Open
AndrewChubatiuk wants to merge 2 commits into
Open
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
vrutkovs
reviewed
May 15, 2026
| if u.RawQuery != "" { | ||
| proxyPath += "?" + u.RawQuery | ||
| } | ||
| return fmt.Sprintf("%s/api/v1/namespaces/%s/services/%s:%s/proxy%s", |
Collaborator
There was a problem hiding this comment.
I think we removed nodes/proxy RBAC permission from the operator anymore - would it still work?
Contributor
Author
There was a problem hiding this comment.
it uses services/proxy, which is already present in cluster-admin role, which is a default role for cli credentials generated by kind
AndrewChubatiuk
force-pushed
the
e2e-removed-validating-job
branch
3 times, most recently
from
dd29f3e to
ec8c408
Compare
AndrewChubatiuk
force-pushed
the
e2e-removed-validating-job
branch
2 times, most recently
from
6b9aa06 to
2af87e2
Compare
AndrewChubatiuk
force-pushed
the
e2e-removed-validating-job
branch
from
2af87e2 to
ad2d5e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Removed the in-cluster Job used for HTTP validation in e2e tests. We now call services via the API server proxy and use watch-based status/deletion waits that fail fast on errors to reduce flakiness and speed up runs.
batch/v1Job +curl; HTTP checks now userest.HTTPClientFor(10s timeout) via the API server proxy, auto-POSTing when a payload is provided.GetRestConfigand plumbedrest.Config(k8sCfg) into tests.buildServiceProxyURLto reach in-cluster services without Pods.Eventuallywith watch-based waits and deletion helpers (expectStatusAfterAction,WatchUntilStatusReached/Seen,waitResourceDeleted/waitObjectDeleted) with generation guards; watchers/status checks now fail fast onUpdateStatusFailed; set default polling interval to 2s.Written for commit ad2d5e7. Summary will update on new commits. Review in cubic