Issue #48 : Migrated to Java 11#54
Conversation
|
Tested locally and works fine with the java-examples I pushed earlier. Also, all unit tests are passing. The check complains because it set up java 8 to run but it will run with java 11. Also, my IntelliJ auto formatted some imports and indentations. |
|
@suratdas thanks for contribution! only now I realised it's not gonna be compatible with java 8 :)
yeah, let's make 11 as minimum required np, I'll make it major version |
Codecov Report
@@ Coverage Diff @@
## master #54 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 27 31 +4
===========================================
Files 5 5
Lines 110 108 -2
Branches 4 4
===========================================
- Hits 110 108 -2
Continue to review full report at Codecov.
|
5376592 to
f12c1c1
Compare
f12c1c1 to
c8565cf
Compare
|
not sure why but jitpack is not building new version |
Looks like we need jitpack.yml file per the comment at jitpack/jitpack.io#2567 (comment) |
|
@pashidlos Did you figure out the jitpack build issue for Java 11 ? Sorry, I never worked with jitpack. So, cannot help immediately. |
|
@suratdas me neither ) |
|
LGTM! |
Fixes #48