Skip to content

VRT will return build statistics on stop.#59

Merged
pashidlos merged 2 commits into
masterfrom
vrtReturningStats
Apr 27, 2021
Merged

VRT will return build statistics on stop.#59
pashidlos merged 2 commits into
masterfrom
vrtReturningStats

Conversation

@suratdas

Copy link
Copy Markdown
Collaborator

When we stop VRT by calling vrt.stop() from Java client, it will return the statistics of how many passed and how many resolved and some more data. This information can be used by the client.

@suratdas
suratdas requested a review from pashidlos April 26, 2021 06:00
Comment thread src/main/java/io/visual_regression_tracker/sdk_java/response/VRTStopResponse.java Outdated
@suratdas
suratdas force-pushed the vrtReturningStats branch from 55fafcd to 231dc64 Compare April 27, 2021 04:13
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #59 (231dc64) into master (f67f11e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master       #59   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        31        31           
===========================================
  Files              5         5           
  Lines            108       108           
  Branches           4         4           
===========================================
  Hits             108       108           
Impacted Files Coverage Δ Complexity Δ
...sion_tracker/sdk_java/VisualRegressionTracker.java 100.00% <100.00%> (ø) 22.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f67f11e...231dc64. Read the comment docs.

@suratdas
suratdas requested a review from pashidlos April 27, 2021 04:16

@pashidlos pashidlos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@suratdas thanks for contribution!

@pashidlos
pashidlos merged commit 655d7ed into master Apr 27, 2021
@pashidlos
pashidlos deleted the vrtReturningStats branch April 27, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants