logback: move test configuration to test/resources and cleaned dependencies#90
Merged
pashidlos merged 2 commits intoJul 18, 2022
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #90 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 31 31
===========================================
Files 5 5
Lines 111 111
Branches 4 4
===========================================
Hits 111 111 Continue to review full report at Codecov.
|
Member
|
@nicerloop thanks for contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logback.xml file in src/resources impacts all projects using the library. This PR moves this file to test/resources to avoid polluting project classpath.
The logback dependency is also moved to be a test dependency, only the slf4j-api dependency is explicitly required by the library.