misc: remove internal id.#26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a companion to freezy/VisualPinball.Engine#408
It removes the
InternalIdparameter that is no longer part of switches, lamps, and coils.A new class
PinMameIdAliaswas created to associate an integer PinMAME id to a VPE string id. All games and MPUs were updated to support having aliases. For example:VisualPinball.Engine.PinMAME/VisualPinball.Engine.PinMAME/MPUs/Wpc.cs
Lines 35 to 51 in dbda3c8
Dictionaries that map PinMAME ids to aliases, and aliases to PinMAME ids have been created to allow for fast lookup.
Note: Any existing projects should have the switches, coils, and lamps refreshed. Single digit PinMAME ids were probably two characters (
01,02,03), and are now single characters (1,2,3).To Do:
PinMameIdAlias?1,10,11,12an issue? (See note above) - Fixed sorting in ManagerListView.csConcatmethod:VisualPinball.Engine.PinMAME/VisualPinball.Engine.PinMAME/PinMameGame.cs
Line 103 in b413449
Concatmethod:VisualPinball.Engine.PinMAME/VisualPinball.Engine.PinMAME/PinMameGame.cs
Line 118 in b413449
PinMameMechConfigVisualPinball.Engine.PinMAME/VisualPinball.Engine.PinMAME.Unity/Runtime/PinMameMechComponent.cs
Line 82 in dbda3c8
VisualPinball.Engine.PinMAME.csprojback to