Enhance SwitchLampUnit to accept comparison type#6
Merged
Conversation
freezy
approved these changes
Jul 7, 2022
Member
freezy
left a comment
There was a problem hiding this comment.
Thanks!
Could you fix the white spaces, then I'll merge. :)
Contributor
Author
|
Fixed. Sorry about that. VS mac seems to have a mind of its own with CR/LF, tabs, spaces on new and existing files. |
Member
|
No worries! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the
SwitchLampUnitto allow for a comparison type to be used when evaluating a match. Prior to this, matches occurred when theValuewas equal to theSource Value.This change allows incrementing variables to be used to turn on / off multiple lamps:
To support the
ComparisonTypeenum displaying symbols instead of the enum value as a string, we created a newAttributedEnumInspector. This allows for overriding the displayed text with theDescriptionattribute.This new
AttributedEnumInspectorwas then reused for theLampDataTypeInspector:When looking at the following image, we see the drop down now shows
On / Offinstead ofOn Off: