Feature/canvas android by j8seangel · Pull Request #5 · Vizzuality/react-native-maps

j8seangel · 2017-05-26T11:55:31Z

This PR includes the custom Canvas Android implementation what adds the below features, ONLY IN ANDROID, TODO: IOS

Offline support,
Custom canvas filter by dates layer.
New interaction layer to highlight the area selected (TODO: improve the highlight size in zoom level changes)

This component extends the UrlTile one and receives the following new params:

areaId: necessary to generate the cached folder.
alertType: supports VIIRS("viirs") and GLAD ("umd_as_it_happens") layers, also mandatory for the cached folder.
isConnected: gets the online status in the app to get from the server or from the cached folder
min and maxDate: dates with the days count from the origin in GLAD('20150101') and 1(today)-8(last-week) to VIIRS.

…native-maps into feature/canvas-android # Conflicts: # lib/android/src/main/java/com/airbnb/android/react/maps/AirMapCanvasUrlTile.java

…vider

…native-maps into feature/canvas-android * 'feature/canvas-android' of github.com:Vizzuality/react-native-maps: Filter alerts by min and max days since the start date in the tileProvider

j8seangel · 2017-05-26T11:58:12Z

Please, don't merge until the master branch is sync with the airbnb master branch to keep the repos synched and make the conflicts easier to solve.
Also remember to remove #feature/canvas-android from the FW repo package.json in "react-native-maps": "Vizzuality/react-native-maps#feature/canvas-android"

j8seangel · 2017-05-26T12:07:33Z

Feel free to merge! (#6)

sorodrigo

Great! I left you some marks on some logs I found.

sorodrigo · 2017-05-29T08:19:13Z

...droid/src/main/java/com/airbnb/android/react/maps/AirMapCanvasInteractionUrlTileManager.java

+
+    @Override
+    public String getName() {
+        Log.d("Map", "Get name");


is this a console log?

sorodrigo · 2017-05-29T10:00:46Z

example/examples/CustomTiles.js

-    const { region } = this.state;
+    const { region, coordinates } = this.state;
+    const hasCoordinates = (coordinates.tile && coordinates.tile.length === 3) || false;
+    console.log(coordinates);


console log

sorodrigo · 2017-05-29T10:01:30Z

lib/android/src/main/java/com/airbnb/android/react/maps/AirMapCanvasUrlTileManager.java

+
+    @Override
+    public String getName() {
+        Log.d("Map", "Get name");


sorodrigo · 2017-05-29T10:02:25Z

lib/android/src/main/java/com/airbnb/android/react/maps/AirMapCanvasTileProvider.java

+
+        if (this.coordinates != null) {
+            int[] tile = this.coordinates.getTile();
+            Log.d("tile Position: ", x + "-" + y + "-" + zoom);


…native-maps into feature/canvas-android * 'feature/canvas-android' of github.com:Vizzuality/react-native-maps: (24 commits) v0.15.2 (react-native-maps#1352) Remove AIRGMSPolyline.h and AIRGMSPolyline.m references from AirMaps.xcodeproj (react-native-maps#1351) v0.15.1 (react-native-maps#1347) fix compile error in rn version >= 0.40 (react-native-maps#1341) Add Marker rotation for Google Maps on iOS (react-native-maps#1326) Fixing reference to AirMapsExplorer in installation docs (react-native-maps#1328) Update README: Use callback in `ref` attribute (react-native-maps#1345) [iOS] Added onPress support for Polyline on Google Maps (react-native-maps#1194) [rnpm] Fix sourceDir for Android (react-native-maps#1313) Update license date (react-native-maps#1316) Fix overlay issues in Android introduced in 0.13.1 (react-native-maps#1311) v0.15.0 (react-native-maps#1305) fixing code snippet (react-native-maps#1196) small typo fixed (react-native-maps#1211) Update installation.md (react-native-maps#1226) Fixed path in `android/settings.gradle` (react-native-maps#1230) Add babelrc to npmignore (react-native-maps#1246) Update installation.md (react-native-maps#1179) Update docs to specify how to access event data (react-native-maps#1178) Update path in android installation (react-native-maps#1249) ...

j8seangel · 2017-05-29T10:37:20Z

Logs removed

geriux · 2017-05-29T11:05:03Z

Awesome work!!!!!!

Gerardo and others added 23 commits May 3, 2017 13:09

Wip: Android tiles

df81ca4

Create intermediateBitmap with appropriate color and alpha and paints it

b529b89

Limit zoom and rescale after that level

29df5cb

Get local tiles

b854609

Remove unneeded logs and code

aebcc55

Scales the map to render the tiles without aliasing

d300083

Merge branch 'feature/canvas-android' of github.com:Vizzuality/react-…

fa93ce1

…native-maps into feature/canvas-android # Conflicts: # lib/android/src/main/java/com/airbnb/android/react/maps/AirMapCanvasUrlTile.java

Pass params from RN

8155426

Default props and view params

67c1acf

Remove unvalid attribute

a7b6ff2

Area id and app document folder

4bc6786

Fix android path

9faaadb

Filter alerts by min and max days since the start date in the tilePro…

fd0152a

…vider

Add interaction canvas layer

09350da

Merge branch 'feature/canvas-android' of github.com:Vizzuality/react-…

4a7f4d7

…native-maps into feature/canvas-android * 'feature/canvas-android' of github.com:Vizzuality/react-native-maps: Filter alerts by min and max days since the start date in the tileProvider

Add interaction custom urltile layer

7f62ccd

New library for tile float part and fix zoom

df85723

Show pixel only within data

b434ef0

Disable fade and add tile size depends on zoom

9c96c70

Add alerts type to support viirs visualization

b3b2eb8

Show VIIRS alerts

06cfd12

Refactor to use custom canvas tile base

d1a3ce1

Fix viirs dates

aa624e2

j8seangel requested review from Bluesmile82, geriux and sorodrigo May 26, 2017 11:55

Merge branch 'master' into feature/canvas-android

754c7bc

sorodrigo suggested changes May 29, 2017

View reviewed changes

j8seangel added 2 commits May 29, 2017 12:36

Remove logs

af13a6c

sorodrigo approved these changes May 29, 2017

View reviewed changes

sorodrigo merged commit 4e9fd7a into master May 29, 2017

sorodrigo deleted the feature/canvas-android branch May 29, 2017 10:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/canvas android#5

Feature/canvas android#5
sorodrigo merged 26 commits intomasterfrom
feature/canvas-android

j8seangel commented May 26, 2017 •

edited

Loading

Uh oh!

j8seangel commented May 26, 2017

Uh oh!

j8seangel commented May 26, 2017 •

edited

Loading

Uh oh!

sorodrigo left a comment

Uh oh!

sorodrigo May 29, 2017

Uh oh!

sorodrigo May 29, 2017

Uh oh!

sorodrigo May 29, 2017

Uh oh!

sorodrigo May 29, 2017

Uh oh!

j8seangel commented May 29, 2017

Uh oh!

geriux commented May 29, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

j8seangel commented May 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

j8seangel commented May 26, 2017

Uh oh!

j8seangel commented May 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sorodrigo left a comment

Choose a reason for hiding this comment

Uh oh!

sorodrigo May 29, 2017

Choose a reason for hiding this comment

Uh oh!

sorodrigo May 29, 2017

Choose a reason for hiding this comment

Uh oh!

sorodrigo May 29, 2017

Choose a reason for hiding this comment

Uh oh!

sorodrigo May 29, 2017

Choose a reason for hiding this comment

Uh oh!

j8seangel commented May 29, 2017

Uh oh!

geriux commented May 29, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

j8seangel commented May 26, 2017 •

edited

Loading

j8seangel commented May 26, 2017 •

edited

Loading