Skip to content

feat(sms): added support for number pooling#1049

Merged
manchuck merged 1 commit intomainfrom
sms-pool-id
Feb 9, 2026
Merged

feat(sms): added support for number pooling#1049
manchuck merged 1 commit intomainfrom
sms-pool-id

Conversation

@manchuck
Copy link
Contributor

Description

Motivation and Context

Testing Details

Example Output or Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@manchuck manchuck requested a review from superchilled January 28, 2026 19:53
Copy link
Contributor

@superchilled superchilled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just wondering if it would make more sense to update this test than have a separate test just for this param?

@manchuck
Copy link
Contributor Author

manchuck commented Feb 9, 2026

@superchilled I normally just add new tests for additions. That helps make sure that we are not introducing a BC

@manchuck manchuck merged commit 3bcf366 into main Feb 9, 2026
15 checks passed
@manchuck manchuck deleted the sms-pool-id branch February 9, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants